Merged
Conversation
srittau
requested changes
Oct 11, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Great, also another complete mark for my COMPLETION.md file. Two remarks below.
Contributor
Author
|
That file is one of the things I'm drawing from, to decide what to make a PR for next. Thank you for making it |
Contributor
Author
|
I could these completion PRs faster, as my pre-review mistakes are from lack of experience with the modules (and Py2, I need to be more careful about checking it for 2and3 modules) more than time spent. I could sit down and work on new ones faster than they're reviewed. However I don't want to just spam-create like 10 PRs, so I've been trying to keep myself to 2 open for review at once |
srittau
approved these changes
Oct 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step in my quest for #1019 completion