Remove unused # type: ignore comments#3325
Merged
JelleZijlstra merged 3 commits intopython:masterfrom Oct 9, 2019
Merged
Conversation
| @@ -9,7 +9,7 @@ from typing import overload, Any, Iterator, Optional, Union, TypeVar | |||
| # is imported in both modules. unfortunately we can't just rename sys, | |||
Member
There was a problem hiding this comment.
Can this comment be removed now? It's not clear exactly what it's referring to; there's nothing unusual in the below code.
Collaborator
Author
There was a problem hiding this comment.
This was introduced in #2887, together with the # type: ignore annotation. @msullivan In case this is still relevant, can we reword the comment to reference the # type: ignore somehow? As an outsider it's hard for me to judge the relevancy of how sys relates to this import or the ignore.
Collaborator
Author
There was a problem hiding this comment.
I have re-added it for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.