Add a type: ignore as a hacky workaround for some mypy bazel issues#2887
Merged
JelleZijlstra merged 1 commit intomasterfrom Mar 27, 2019
Merged
Add a type: ignore as a hacky workaround for some mypy bazel issues#2887JelleZijlstra merged 1 commit intomasterfrom
JelleZijlstra merged 1 commit intomasterfrom
Conversation
gvanrossum
approved these changes
Mar 26, 2019
Member
|
I'm OK with this, but pytype apparently doesn't like |
Member
|
We noticed. :-) Maybe pytype doesn't like |
Collaborator
|
Looks like pytype doesn't like |
rchen152
added a commit
to google/pytype
that referenced
this pull request
Mar 27, 2019
Our parser is causing problems for python/typeshed#2887 (comment). Most of the new tests call parse_string() directly instead of using _ParserTestBase.check() because the ast contains internal details like the use of __PACKAGE__ for the current package. PiperOrigin-RevId: 240610622
Collaborator
|
The pytype issue was fixed in pytype 2019.03.27. |
Member
|
Thanks @rchen152! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.