Merged
Conversation
Contributor
Author
|
(Effectively a follow-up from #3154 :)) |
srittau
requested changes
Sep 28, 2019
Collaborator
srittau
left a comment
There was a problem hiding this comment.
Thank you. Per the implementation __call__ should actually be defined on dateutil._common.weekday and use a type variable:
def __call__(self: Type[_T], n: int) -> _T: ...This way all sub-classes get the correct type.
Contributor
Author
|
Thanks @srittau - will update. |
srittau
requested changes
Oct 3, 2019
| def __init__(self, weekday: int, n: Optional[int] = ...) -> None: ... | ||
|
|
||
| def __call__(self, n: int) -> weekday: ... | ||
| def __call__(self: Type[_T], n: int) -> _T: ... |
Collaborator
There was a problem hiding this comment.
Sorry, that was an error on my part. The Type is nonsense. It's just self: _T as self has the same type as the return value. Thatswhy the tests fail.
Contributor
Author
There was a problem hiding this comment.
No worries. Should have caught it locally :-P. Let me try again…
srittau
approved these changes
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rrule.weekday(...) returns new rrule.weekday objects, not _common.weekday.