Skip to content

dateutil.rrule.rrule can take dates#3154

Merged
srittau merged 1 commit intopython:masterfrom
akaptur:dateutil-rrules
Jul 27, 2019
Merged

dateutil.rrule.rrule can take dates#3154
srittau merged 1 commit intopython:masterfrom
akaptur:dateutil-rrules

Conversation

@akaptur
Copy link
Contributor

@akaptur akaptur commented Jul 26, 2019

dateutil.rrule.rrule's dtstart and until flags are both compatible with date as well as datetime and will convert from the former to the latter. See here.

I'm assuming that the typeshed should reflect the types as actually implemented, as opposed to how they're documented - dtstart is passingly referred to in the docs as a "date", which is a bit ambiguous but doesn't create any problems. But until is mis-documented, saying:

If given, this must be a datetime instance specifying the upper-bound limit of the recurrence.

... even though the code will happily convert from a date to a datetime.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 15aa18d into python:master Jul 27, 2019
@glyph glyph mentioned this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants