Skip to content

Revert "Define functools.partial as overloaded function instead of its own class"#3077

Merged
JelleZijlstra merged 1 commit intomasterfrom
revert-2878-overloaded_partial
Jun 21, 2019
Merged

Revert "Define functools.partial as overloaded function instead of its own class"#3077
JelleZijlstra merged 1 commit intomasterfrom
revert-2878-overloaded_partial

Conversation

@JelleZijlstra
Copy link
Member

Reverts #2878

Caused problems in many real-world codebases. Proper support for partial will have to come from a plugin instead.

I've seen the following problems reported:

  • Keyword arguments to partial() functions no longer work
  • isinstance() checks on functools.partial no longer work
  • Access to .func and other attributes no longer works

@JelleZijlstra JelleZijlstra requested review from JukkaL and srittau June 20, 2019 14:53
@JelleZijlstra JelleZijlstra merged commit ada0570 into master Jun 21, 2019
@JelleZijlstra JelleZijlstra deleted the revert-2878-overloaded_partial branch June 21, 2019 03:40
JelleZijlstra added a commit that referenced this pull request Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants