Jinja2 async support #2278
Merged
Jinja2 async support #2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def debug_info(self): ... | ||
|
|
||
| if sys.version_info >= (3, 6): | ||
| from typing import Awaitable, AsyncIterator |
Member
There was a problem hiding this comment.
Could you put these imports in a separate if sys.version_info block at the top? An import statement within a class seems, um, unusual.
Member
|
Looks good, just had one comment. |
Contributor
Author
|
Done. |
JelleZijlstra
approved these changes
Jun 28, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubs for
Environment.enable_asyncparameter,Template.render_asyncandTemplate.generate_asyncmethods.Reference:
http://jinja.pocoo.org/docs/2.10/api/#async-support