Conversation
JelleZijlstra
left a comment
There was a problem hiding this comment.
This change seems fine but if more rules make it out of Ruff's preview we'll have to evaluate whether we still want them.
|
There's no harm on waiting on this one for Ruff 0.9 or running it in preview mode to see what it affects. |
|
Some of the refurb rules in preview have been in preview for quite a while now. The reason is that they're extremely opinionated rules that I expect a significant portion of Ruff's users would disagree with. These rules can't realistically be stabilised until we've figured out a better way of signalling that a certain rule makes highly opinionated recommendations, which probably requires astral-sh/ruff#1774. I'd recommend for typeshed to just select the rules it finds useful from this category, rather than the whole category, in case Ruff's policy here changes and we end up stabilising some of these very opinionated rules that make debatable recommendations. |
Co-authored-by: Avasam <samuel.06@hotmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Ref #13295
https://docs.astral.sh/ruff/rules/#refurb-furb
A single autofixable change. Otherwise we already pass all refurb rules.
Although a lot of those rules are still in preview.