Skip to content

PEP 621: Fix missing schemes in example project.urls#2621

Merged
brettcannon merged 1 commit intopython:mainfrom
Julian:patch-1
May 30, 2022
Merged

PEP 621: Fix missing schemes in example project.urls#2621
brettcannon merged 1 commit intopython:mainfrom
Julian:patch-1

Conversation

@Julian
Copy link
Contributor

@Julian Julian commented May 30, 2022

PyPI seems to reject these as-is (probably expectedly).

PyPI seems to reject these as-is (probably expectedly).
@Julian
Copy link
Contributor Author

Julian commented May 30, 2022

This seems correct based on an error I got from PyPI when emulating this verbatim, but apologies if I've missed something of course.

@AA-Turner
Copy link
Member

Core metadata says "A string containing a browsable URL for the project and a label for it, separated by a comma.". As such it seems the scheme is required, although the language could be tighter.

A

Julian added a commit to python-jsonschema/jsonschema that referenced this pull request May 30, 2022
@brettcannon brettcannon merged commit 6b88b04 into python:main May 30, 2022
@brettcannon
Copy link
Member

Thanks!

@Julian Julian deleted the patch-1 branch May 30, 2022 21:14
@CAM-Gerlach
Copy link
Member

Just to note, the canonical living spec is on the PyPUG PyPA specifications page, but it (perhaps unfortunately) doesn't include the examples.

Core metadata says "A string containing a browsable URL for the project and a label for it, separated by a comma.". As such it seems the scheme is required, although the language could be tighter.

For completeness, that's core metadata; PEP 621 could specify a deterministic transform between the URLs in the project source metadata and the values in the output core metadata fields (as is true for other entries)—it doesn't, so its a moot point, but what matters is what is specified in PEP 621 rather than necessarily core metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants