Promote memoryview to bytes#7717
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Oct 15, 2019
Merged
Conversation
srittau
added a commit
to srittau/typeshed
that referenced
this pull request
Oct 15, 2019
Necessary for python/mypy#7717
Contributor
Author
|
When running the tests locally with Are the Python 2 tests not run during CI? python/typeshed#3365 will fix this, though. |
Member
Good point! It looks like at least |
ilevkivskyi
approved these changes
Oct 15, 2019
Member
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks for the quick fix! LGTM.
Member
|
We can land this after the typeshed PR is landed an synced. |
srittau
added a commit
to python/typeshed
that referenced
this pull request
Oct 15, 2019
BoboTiG
pushed a commit
to nuxeo/nuxeo-drive
that referenced
this pull request
Nov 25, 2019
Fixed these errors:
manager.py:636:
Incompatible return value type (got "Optional[str]", expected "str")
commandline.py:574:
On Python 3 '{}'.format(b'abc') produces "b'abc'"; use !r if this is a desired behavior
There is also a false positive ignored for now
(should be fixed in the next mypy release, see
python/mypy#7717).
BoboTiG
pushed a commit
to nuxeo/nuxeo-drive
that referenced
this pull request
Nov 25, 2019
Fixed these errors:
manager.py:636:
Incompatible return value type (got "Optional[str]", expected "str")
commandline.py:574:
On Python 3 '{}'.format(b'abc') produces "b'abc'"; use !r if this is a desired behavior
There is also a false positive ignored for now
(should be fixed in the next mypy release, see
python/mypy#7717).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7714
Currently this fails a lot of seemingly unrelated tests. I will investigate later.