Match note error codes to import error codes by hauntsaninja · Pull Request #16004 · python/mypy

hauntsaninja · 2023-08-31T01:35:48Z

Fixes #16003. Follow up to #14740

JelleZijlstra · 2023-08-31T01:57:45Z

You'll need to update some ignores in mypy itself:

mypy/report.py:28: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
        from lxml import etree  # type: ignore[import]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mypy/test/testreports.py:10: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
        import lxml  # type: ignore[import]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mypy/test/testreports.py:25: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
            import lxml.etree as etree  # type: ignore[import]
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mypy/test/testcmdline.py:[23](https://github.com/python/mypy/actions/runs/6031989547/job/16366518197?pr=16004#step:8:24): error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
        import lxml  # type: ignore[import]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mypy/test/testcheck.py:29: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
        import lxml  # type: ignore[import]
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 5 errors in 4 files (checked [28](https://github.com/python/mypy/actions/runs/6031989547/job/16366518197?pr=16004#step:8:29)6 source files)

github-actions · 2023-08-31T03:33:51Z

Diff from mypy_primer, showing the effect of this PR on open source code:

poetry (https://github.com/python-poetry/poetry)
+ src/poetry/installation/chef.py:16: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]

schema_salad (https://github.com/common-workflow-language/schema_salad)
+ schema_salad/tests/memory-leak-check.py:5: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ schema_salad/tests/memory-leak-check.py:6: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]

mypy (https://github.com/python/mypy)
+ mypy/report.py:28: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ mypy/test/testreports.py:10: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ mypy/test/testreports.py:25: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ mypy/test/testcmdline.py:23: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ mypy/test/testcheck.py:29: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]

jax (https://github.com/google/jax)
+ jax/_src/pickle_util.py:21: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ jax/experimental/jax2tf/examples/tf_js/quickdraw/quickdraw.py:33: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ jax/experimental/jax2tf/examples/serving/model_server_request.py:18: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ jax/experimental/jax2tf/examples/serving/model_server_request.py:30: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ jax/experimental/jax2tf/examples/serving/model_server_request.py:31: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ jax/experimental/jax2tf/examples/tflite/mnist/mnist.py:25: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]

spark (https://github.com/apache/spark)
+ python/pyspark/profiler.py:41: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ python/pyspark/accumulators.py:30: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ python/pyspark/pandas/sql_processor.py:18: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]

aiohttp (https://github.com/aio-libs/aiohttp)
+ aiohttp/http_writer.py:192: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ aiohttp/http_websocket.py:163: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ aiohttp/http_parser.py:918: error: Unused "type: ignore[import]" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
- aiohttp/pytest_plugin.py:23:1: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-import for more info

urllib3 (https://github.com/urllib3/urllib3)
+ src/urllib3/util/request.py:24: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/util/request.py:26: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/util/request.py:32: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/response.py:19: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/response.py:21: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/response.py:26: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/contrib/socks.py:44: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ src/urllib3/contrib/pyopenssl.py:43: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ src/urllib3/contrib/pyopenssl.py:73: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]
+ test/__init__.py:21: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ test/__init__.py:23: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ test/__init__.py:28: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ test/contrib/test_socks.py:12: error: Unused "type: ignore" comment, use narrower [import-not-found] instead of [import] code  [unused-ignore]
+ test/contrib/test_pyopenssl.py:10: error: Unused "type: ignore" comment, use narrower [import-untyped] instead of [import] code  [unused-ignore]

hauntsaninja · 2023-08-31T04:09:53Z

Note that the subcode logic is that we only the diagnostic about narrower error codes with --warn-unused-ignore and without --ignore-missing-imports. Note that mypy_primer forcefully enables --warn-unused-ignore.

If we want to reduce cost of this change, some options are:
a) provide a script to update the type ignores,
b) make the narrow check be part of ignore-without-code instead of --warn-unused-ignore,
c) use a subcode of unused-ignore for this case :-D

Fixes #16003. Follow up to #14740

Match note error codes to import error codes

f46bf76

Fixes python#16003

This was referenced Aug 31, 2023

type: ignore[import-untyped] leaves a hard-to-suppress note #16003

Closed

Mypy 1.6 Release Planning #15919

Closed

This comment has been minimized.

Sign in to view

fix self check

79c8cfe

This comment has been minimized.

Sign in to view

fix test

9ddf6b7

hauntsaninja merged commit 17e9e22 into python:master Sep 2, 2023

hauntsaninja deleted the import-error-cod branch September 2, 2023 05:47

JukkaL pushed a commit that referenced this pull request Oct 10, 2023

Match note error codes to import error codes (#16004)

e78df55

Fixes #16003. Follow up to #14740

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Match note error codes to import error codes#16004

Match note error codes to import error codes#16004
hauntsaninja merged 3 commits intopython:masterfrom
hauntsaninja:import-error-cod

hauntsaninja commented Aug 31, 2023 •

edited

Loading

Uh oh!

This comment has been minimized.

JelleZijlstra commented Aug 31, 2023

Uh oh!

This comment has been minimized.

github-actions bot commented Aug 31, 2023

Uh oh!

hauntsaninja commented Aug 31, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hauntsaninja commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

JelleZijlstra commented Aug 31, 2023

Uh oh!

This comment has been minimized.

github-actions bot commented Aug 31, 2023

Uh oh!

hauntsaninja commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hauntsaninja commented Aug 31, 2023 •

edited

Loading

hauntsaninja commented Aug 31, 2023 •

edited

Loading