Optimize Unpack for failures#15967
Merged
ilevkivskyi merged 2 commits intopython:masterfrom Aug 29, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
pushed a commit
that referenced
this pull request
Oct 10, 2023
This is a small but possibly important PR. Wherever possible we should represent user error and/or failed type inference as `*tuple[Any, ...]`/`*tuple[<nothing>, ...]`, rather than `Unpack[Any]`/`Unpack[<nothing>]` or plain `Any`/`<nothing>`. This way we will not need any special casing for failure conditions in various places without risking a crash instead of a graceful failure (error message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small but possibly important PR. Wherever possible we should represent user error and/or failed type inference as
*tuple[Any, ...]/*tuple[<nothing>, ...], rather thanUnpack[Any]/Unpack[<nothing>]or plainAny/<nothing>. This way we will not need any special casing for failure conditions in various places without risking a crash instead of a graceful failure (error message).