Merged
Conversation
pytest 7.4.0 was just released, and our CI is red as a result. Looks like we're using a private API that we shouldn't be. For now let's just pin to pytest <7.4.0
sobolevn
approved these changes
Jun 23, 2023
Member
sobolevn
left a comment
There was a problem hiding this comment.
I think we can also bump the lower bound to >=7.3, but it is totally not required.
Member
Author
I'd generally pin pytest to an exact version in my own projects, since it's a test dependency, but the approach elsewhere in this file seems to be to be as permissive as possible with the ranges... happy to go either way, though! |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
pushed a commit
that referenced
this pull request
Jun 24, 2023
pytest 7.4.0 was just released, and our CI on `master` is very red as a result. Looks like we're using a private API that we shouldn't be: #15501 (comment). For now let's just pin to pytest <7.4.0. https://pypi.org/project/pytest/7.4.0/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 7.4.0 was just released, and our CI on
masteris very red as a result. Looks like we're using a private API that we shouldn't be: #15501 (comment). For now let's just pin to pytest <7.4.0.https://pypi.org/project/pytest/7.4.0/