Fix ResourceWarning due to unclosed file resource.#274
Merged
jaraco merged 2 commits intopython:mainfrom Dec 6, 2022
tirkarthi:fix-warnings
Merged
Fix ResourceWarning due to unclosed file resource.#274jaraco merged 2 commits intopython:mainfrom tirkarthi:fix-warnings
jaraco merged 2 commits intopython:mainfrom
tirkarthi:fix-warnings
Conversation
Member
|
I wonder why this test suite doesn't emit the warnings. Aah. So it seems Python ignores ResourceWarnings by default. I've opened jaraco/skeleton#73 to ensure this issue doesn't occur in any other skeleton-backed projects. |
Member
|
Released as v5.10.1. Will get synced with CPython in the future. I'll try not to let it linger into 2023. |
Member
Author
|
Thanks @jaraco |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes below warnings that were originally found in CPython test suite.