Skip to content

gh-99433: Fix doctest failure on MethodWrapperType#99434

Merged
kumaraditya303 merged 1 commit intopython:mainfrom
sobolevn:issue-99433
Dec 30, 2022
Merged

gh-99433: Fix doctest failure on MethodWrapperType#99434
kumaraditya303 merged 1 commit intopython:mainfrom
sobolevn:issue-99433

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Nov 13, 2022 •
edited
Loading

Looks like it was failing because isroutine now has ismethodwrapper check. While _from_module was not having one. Refs https://github.com/python/cpython/blame/57be5459593bbd09583317ebdafc4d58ae51dbf4/Lib/inspect.py#L509

New test failure without the code change:

======================================================================
FAIL: basics (test.test_doctest.test_DocTestFinder)
Doctest: test.test_doctest.test_DocTestFinder.basics
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/Lib/doctest.py", line 2221, in runTest
    raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for test.test_doctest.test_DocTestFinder.basics
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_doctest.py", line 437, in basics

----------------------------------------------------------------------
File "/Users/sobolev/Desktop/cpython/Lib/test/test_doctest.py", line 649, in test.test_doctest.test_DocTestFinder.basics
Failed example:
    tests = doctest.DocTestFinder(exclude_empty=False).find(doctest_lineno)
Exception raised:
    Traceback (most recent call last):
      ...
    ValueError: object must be a class or function
----------------------------------------------------------------------

This would need a backport to 3.11

@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Closed
@sobolevn sobolevn added the needs backport to 3.11 only security fixes label Nov 13, 2022
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Dec 24, 2022

@larryhastings @isidentical you work on inspect quite a lot, maybe you would have time to take a look? :)

kumaraditya303
kumaraditya303 approved these changes Dec 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 79c10b7 into python:main Dec 30, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 30, 2022

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 30, 2022

GH-100620 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2022
@sobolevn @miss-islington
pythongh-99433: Fix doctest failure on types.MethodWrapperType (p…
e248ccc 
…ythonGH-99434)

(cherry picked from commit 79c10b7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Dec 30, 2022
@miss-islington @sobolevn
gh-99433: Fix doctest failure on types.MethodWrapperType (GH-99434)
c88a83e 
(cherry picked from commit 79c10b7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @miss-islington @bedevere-bot @kumaraditya303