Skip to content

gh-96250: Improve sqlite3 injection attack example#99270

Merged
erlend-aasland merged 6 commits intopython:mainfrom
jiajunjie:gh-96250
Dec 8, 2022
Merged

gh-96250: Improve sqlite3 injection attack example#99270
erlend-aasland merged 6 commits intopython:mainfrom
jiajunjie:gh-96250

Conversation

@jiajunjie
Copy link
Copy Markdown
Contributor

@jiajunjie jiajunjie commented Nov 9, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 9, 2022
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 9, 2022
@erlend-aasland erlend-aasland self-assigned this Nov 9, 2022
@erlend-aasland
Copy link
Copy Markdown
Contributor

erlend-aasland commented Nov 9, 2022

Thanks so much, Jia! I've taken the liberty to reflowing the comment because of the 79 char limit; hope you don't mind.

erlend-aasland
erlend-aasland reviewed Nov 9, 2022
View reviewed changes
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 9, 2022
@jiajunjie jiajunjie requested review from erlend-aasland and removed request for berkerpeksag November 16, 2022 01:35
@CAM-Gerlach
Copy link
Copy Markdown
Member

CAM-Gerlach commented Nov 16, 2022

Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the >>> button to show only copyable code, no?

@erlend-aasland
Copy link
Copy Markdown
Contributor

erlend-aasland commented Nov 16, 2022

Minor sidenote, but it looks a little strange to me to enter comments at the interactive prompt. Maybe just enter them without the prompt, since they should still be displayed as "output" and don't really need to be shown when clicking the >>> button to show only copyable code, no?

Even better, make them part of the prose.

erlend-aasland
erlend-aasland reviewed Nov 16, 2022
View reviewed changes
@erlend-aasland
Copy link
Copy Markdown
Contributor

erlend-aasland commented Nov 24, 2022

@jiajunjie, ping me when you've addressed the review remarks :)

CAM-Gerlach
CAM-Gerlach approved these changes Dec 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jiajunjie !

erlend-aasland
erlend-aasland approved these changes Dec 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@erlend-aasland erlend-aasland merged commit 41d4ac9 into python:main Dec 8, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 8, 2022

Thanks @jiajunjie for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 8, 2022

GH-100119 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 8, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 8, 2022

GH-100120 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 8, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2022
@jiajunjie @CAM-Gerlach
@erlend-aasland @miss-islington
pythongh-96250: Improve sqlite3 injection attack example (pythonGH-99270
d473e77 
)

(cherry picked from commit 41d4ac9)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 8, 2022
@jiajunjie @CAM-Gerlach
@erlend-aasland @miss-islington
pythongh-96250: Improve sqlite3 injection attack example (pythonGH-99270
2507938 
)

(cherry picked from commit 41d4ac9)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Dec 8, 2022
@miss-islington @jiajunjie
@CAM-Gerlach @erlend-aasland
gh-96250: Improve sqlite3 injection attack example (GH-99270)
8ef6045 
(cherry picked from commit 41d4ac9)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request Dec 8, 2022
@miss-islington @jiajunjie
@CAM-Gerlach @erlend-aasland
gh-96250: Improve sqlite3 injection attack example (GH-99270)
ecb16d5 
(cherry picked from commit 41d4ac9)

Co-authored-by: Jia Junjie <62194633+jiajunjie@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jiajunjie @erlend-aasland @CAM-Gerlach @miss-islington @bedevere-bot