Skip to content

bpo-32174: Let .chm document display non-ASCII characters properly#9758

Merged
zooba merged 2 commits into
masterfrom
unknown repository
Oct 8, 2018
Merged

bpo-32174: Let .chm document display non-ASCII characters properly#9758
zooba merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 8, 2018

Copy link
Copy Markdown

Escape the body part of .chm source to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.

https://bugs.python.org/issue32174

Escape the `body` part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.
@zooba zooba merged commit 6261ae9 into python:master Oct 8, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @animalize for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2018
…ythonGH-9758)

Let .chm document display non-ASCII characters properly

Escape the `body` part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.
(cherry picked from commit 6261ae9)

Co-authored-by: animalize <animalize@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-9762 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2018
…ythonGH-9758)

Let .chm document display non-ASCII characters properly

Escape the `body` part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.
(cherry picked from commit 6261ae9)

Co-authored-by: animalize <animalize@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-9763 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Oct 8, 2018
…H-9758)

Let .chm document display non-ASCII characters properly

Escape the `body` part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.
(cherry picked from commit 6261ae9)

Co-authored-by: animalize <animalize@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Oct 8, 2018
…H-9758)

Let .chm document display non-ASCII characters properly

Escape the `body` part of .chm source file to 7-bit ASCII, to fix visual effect on some MBCS Windows systems.
(cherry picked from commit 6261ae9)

Co-authored-by: animalize <animalize@users.noreply.github.com>
@ghost ghost deleted the issue32174 branch October 10, 2018 14:57
@mcepl

mcepl commented Oct 18, 2018

Copy link
Copy Markdown
Contributor

@zooba , @vstinner Is it a good idea to build .chm files even on Mac OS X/Linux, where they don't have much any use? (Not mentioning, it adds dependence on escape4chm plugin on all platforms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants