bpo-34921: No return not allowed by get_type_hints; line 133 …#9750
bpo-34921: No return not allowed by get_type_hints; line 133 …#9750ilevkivskyi merged 2 commits intopython:masterfrom NoahGWood:fix-issue-34921
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! Just one minor style comment, otherwise looks good. Also please sign the CLA.
|
It looks like something is wrong with CLA bot. I checked on https://check-python-cla.herokuapp.com/ that the CLA is signed few hours ago, but the label is still red. I am going to merge this. |
bpo-34921: Modified line 133 in Lib/typing.py to fix get_type_hints(NoReturn)
https://bugs.python.org/issue34921