Skip to content

gh-96357: Improve typing.get_overloads coverage#96358

Merged
JelleZijlstra merged 1 commit intopython:mainfrom
sobolevn:issue-96357
Aug 29, 2022
Merged

gh-96357: Improve typing.get_overloads coverage#96358
JelleZijlstra merged 1 commit intopython:mainfrom
sobolevn:issue-96357

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Aug 28, 2022 •
edited by bedevere-bot
Loading

Right now it is fully covered:
Снимок экрана 2022-08-28 в 11 58 38

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 28, 2022
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Aug 28, 2022

Retriggering

@sobolevn sobolevn closed this Aug 28, 2022
@sobolevn sobolevn reopened this Aug 28, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 29, 2022
@JelleZijlstra JelleZijlstra merged commit 675e347 into python:main Aug 29, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 29, 2022

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2022
@sobolevn @miss-islington
pythongh-96357: Improve typing.get_overloads coverage (pythonGH-96358)
2e9c031 
(cherry picked from commit 675e347)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 29, 2022

Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 675e3470ccf3804a36a9cd451b813e9bd655aeb3 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 29, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 29, 2022

GH-96371 is a backport of this pull request to the 3.11 branch.

@JelleZijlstra
Copy link
Copy Markdown
Member

JelleZijlstra commented Aug 29, 2022

duh, it's not in 3.10 :)

@AlexWaygood AlexWaygood removed the needs backport to 3.10 only security fixes label Aug 29, 2022
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Aug 29, 2022

Thank you!

sobolevn added a commit to sobolevn/typing_extensions that referenced this pull request Aug 29, 2022
@sobolevn
Backport test case from #python/cpython/96358
4653ade 
Original PR: python/cpython#96358
@sobolevn sobolevn mentioned this pull request Aug 29, 2022
Merged
JelleZijlstra pushed a commit that referenced this pull request Sep 29, 2022
@miss-islington @sobolevn
[3.11] gh-96357: Improve typing.get_overloads coverage (GH-96358) (#…
f418842 
…96371)

gh-96357: Improve `typing.get_overloads` coverage (GH-96358)
(cherry picked from commit 675e347)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @AlexWaygood