Skip to content

gh-95380: Remove limitation of 1024 max path size for fcntl#95429

Closed
gst wants to merge 1 commit into
python:mainfrom
gst:fix-fcntl-1024-limit
Closed

gh-95380: Remove limitation of 1024 max path size for fcntl#95429
gst wants to merge 1 commit into
python:mainfrom
gst:fix-fcntl-1024-limit

Conversation

@gst

@gst gst commented Jul 29, 2022

Copy link
Copy Markdown
Contributor

@gst gst force-pushed the fix-fcntl-1024-limit branch 3 times, most recently from 2e4ff61 to ab78e70 Compare July 29, 2022 14:30
@gst gst marked this pull request as ready for review July 29, 2022 15:04
arhadthedev added a commit to arhadthedev/cpython that referenced this pull request Jul 29, 2022
Пулл-реквест pythongh-95429 внёс по сути те же изменения, так что фокусируемся
на отсутствующем там fcntl_ioctl_impl.
Comment thread Misc/NEWS.d/next/Core and Builtins/2022-07-29-09-52-22.gh-issue-95380.p8S_K0.rst Outdated
@gst gst force-pushed the fix-fcntl-1024-limit branch from ab78e70 to 3bc8cee Compare July 30, 2022 13:12
@JelleZijlstra

Copy link
Copy Markdown
Member

I'm fairly sure this will write past the end of the buffer if you pass a buffer that is smaller than PATH_MAX. For example, on MacOS a call like fcntl.fcntl(f.fileno(), fcntl.F_GETPATH, b"") looks like it would write the filename into whatever memory is next to the empty buffer.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
@JelleZijlstra

Copy link
Copy Markdown
Member

Closing as there is four-year-old unanswered feedback, there's a merge conflict, and the issue has been fixed in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants