bpo-34687: asynico uses ProactorEventLoop by default #9538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, asyncio now uses ProactorEventLoop, instead of SelectorEventLoop.
1st1
requested changes
Sep 24, 2018
Doc/library/asyncio-platforms.rst
Outdated
| Windows | ||
| ======= | ||
|
|
||
| The default event loop on Windows is :class:`ProactorEventLoop`. |
Member
There was a problem hiding this comment.
Just put one .. versionchanged:: 3.8 here, there's no point in covering this info twice in this section.
Doc/library/asyncio-platforms.rst
Outdated
| asyncio.run(your_code()) | ||
| The default event loop :class:`ProactorEventLoop` supports subprocesses. | ||
|
|
||
| On Windows, :class:`SelectorEventLoop` does not support subprocesses. |
Member
There was a problem hiding this comment.
On Windows, the default event loop :class:ProactorEventLoop supports subprocesses, whereas :class:SelectorEventLoop does not.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @1st1: please review the changes made to this pull request. |
1st1
reviewed
Sep 24, 2018
| is configured to use the default policy automatically. | ||
|
|
||
|
|
||
| .. class:: WindowsSelectorEventLoopPolicy |
Member
There was a problem hiding this comment.
Oh, one more change... 5 lines above this line:
The default asyncio policy. Uses :class:`SelectorEventLoop`
on both Unix and Windows platforms.
There is no need to install the default policy manually. asyncio
is configured to use the default policy automatically.
please change it to
The default asyncio policy. Uses :class:`SelectorEventLoop`
on Unix and :class:`ProactorEventLoop` on Windows.
There is no need to install the default policy manually. asyncio
is configured to use the default policy automatically.
.. versionchanged:: 3.8
:class:`ProactorEventLoop` is now default on Windows.
1st1
approved these changes
Sep 25, 2018
Harmon758
added a commit
to Harmon758/Harmonbot
that referenced
this pull request
Jan 5, 2020
For Windows, for which it's now the default for in Python 3.8: https://bugs.python.org/issue34687 python/cpython#9538 python/cpython@6ea29c5 https://docs.python.org/3/whatsnew/3.8.html#asyncio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, asyncio now uses ProactorEventLoop, instead of
SelectorEventLoop, by default.
https://bugs.python.org/issue34687