Skip to content

gh-95174: Handle missing dup() and constants in WASI#95229

Merged
tiran merged 1 commit intopython:mainfrom
tiran:gh-95174-dup-constants
Jul 26, 2022
Merged

gh-95174: Handle missing dup() and constants in WASI#95229
tiran merged 1 commit intopython:mainfrom
tiran:gh-95174-dup-constants

Conversation

@tiran
Copy link
Copy Markdown
Member

@tiran tiran commented Jul 25, 2022 •
edited by bedevere-bot
Loading

  • check for dup() libc function
  • handle missing F_DUPFD in dup2() replacement function
  • add workaround for WASI libc bug in MSG_TRUNC
  • ESHUTDOWN is missing, use EPIPE instead
  • POLLPRI is missing, define as 0 (no-op)

@tiran tiran added the needs backport to 3.11 only security fixes label Jul 25, 2022
@tiran tiran requested a review from a team as a code owner July 25, 2022 07:08
This was referenced Jul 25, 2022
Merged
Merged
@tiran tiran requested a review from brettcannon July 25, 2022 13:31
@tiran
pythongh-95174: Handle missing dup() and constants in WASI
879f63e 
- check for ``dup()`` libc function
- handle missing ``F_DUPFD`` in ``dup2()`` replacement function
- add workaround for WASI libc bug in MSG_TRUNC
- ESHUTDOWN is missing, use EPIPE instead
- POLLPRI is missing, define as 0 (no-op)
@tiran tiran force-pushed the gh-95174-dup-constants branch from c950dbc to 879f63e Compare July 25, 2022 13:36
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 25, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 879f63e 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@tiran tiran merged commit 0d35a59 into python:main Jul 26, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 26, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 26, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0d35a59ce3242b7326890a8c8cc41b321192ec9a 3.11

@tiran tiran deleted the gh-95174-dup-constants branch July 26, 2022 09:16
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 26, 2022

GH-95272 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 26, 2022
tiran added a commit to tiran/cpython that referenced this pull request Jul 31, 2022
@tiran
[3.11] pythongh-95174: Handle missing dup() and constants in WASI (py…
dfdb0d3 
…thonGH-95229)

- check for ``dup()`` libc function
- handle missing ``F_DUPFD`` in ``dup2()`` replacement function
- add workaround for WASI libc bug in MSG_TRUNC
- ESHUTDOWN is missing, use EPIPE instead
- POLLPRI is missing, define as 0 (no-op).
(cherry picked from commit 0d35a59)

Co-authored-by: Christian Heimes <christian@python.org>
pablogsal pushed a commit that referenced this pull request Jul 31, 2022
@tiran
[3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (
db13c0c 
GH-95272)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran @bedevere-bot @miss-islington