Skip to content

gh-95060: PyCode_Addr2Location return when addrq < 0#95091

Merged
markshannon merged 2 commits intopython:mainfrom
Fidget-Spinner:code_addr2location_assert
Jul 21, 2022
Merged

gh-95060: PyCode_Addr2Location return when addrq < 0#95091
markshannon merged 2 commits intopython:mainfrom
Fidget-Spinner:code_addr2location_assert

Conversation

@Fidget-Spinner
Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner commented Jul 21, 2022

@Fidget-Spinner Fidget-Spinner changed the title PyCode_Addr2Location return when addrq < 0 gh-95060: PyCode_Addr2Location return when addrq < 0 Jul 21, 2022
@Fidget-Spinner
Copy link
Copy Markdown
Member Author

Untested (?) code means all tests pass :)

@markshannon markshannon added the needs backport to 3.11 only security fixes label Jul 21, 2022
@markshannon
Copy link
Copy Markdown
Member

We should probably add some tests for this. But I don't think we need to do that for the backport.

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @Fidget-Spinner for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-95094 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 21, 2022
(cherry picked from commit a6daaf2)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@Fidget-Spinner Fidget-Spinner deleted the code_addr2location_assert branch July 21, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants