gh-93939: Add script to check extension modules#94545
Conversation
Add script ``Tools/scripts/check_modules.py`` to check and validate builtin and shared extension modules. The script also handles ``Modules/Setup`` and will eventually replace ``setup.py``.
vstinner
left a comment
There was a problem hiding this comment.
"check modules" is very generic. Would you mind to elaborate the purpose of the script? I understand that the purpose is to check which modules are built successfully and which ones are disabled. Maybe say "check modules build"?
It seems like the script also renames extensions which cannot be imported.
Please elaborate the docstring of the script also.
|
Do you have an idea for a better name? check_extension_modules maybe? |
check_extensions_build or check_built_extensions. |
|
The script does the same as |
vstinner
left a comment
There was a problem hiding this comment.
Thanks for the updated docstring.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
erlend-aasland
left a comment
There was a problem hiding this comment.
I took only a quick glance for now. If this can replace setup.py, this is a very nice improvement to the build system!
Should we add a check that adds a user-friendly warning if you try to run this script in the source directory? Someone will create an issue about that in the future.
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
Add script
Tools/scripts/check_modules.pyto check and validate builtinand shared extension modules. The script also handles
Modules/Setupandwill eventually replace
setup.py.