bpo-34738: Add directory entries in ZIP files created by distutils.#9419
Merged
serhiy-storchaka merged 3 commits intoDec 5, 2018
Merged
Conversation
merwok
approved these changes
Dec 5, 2018
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…ythonGH-9419) (cherry picked from commit 67a93b3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10941 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2018
…ythonGH-9419) (cherry picked from commit 67a93b3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10942 is a backport of this pull request to the 3.6 branch. |
Member
Author
|
Thank you for your review @merwok! |
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Dec 5, 2018
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Dec 5, 2018
…ils. (pythonGH-9419). (cherry picked from commit 67a93b3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-10950 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 5, 2018
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 5, 2018
jcfr
added a commit
to scikit-build/scikit-build
that referenced
this pull request
May 11, 2019
This commit fixes tests that are checking content of sdist to account for changes introduced in Python 3.8 and backported to python 2.7, 3.6 and 3.7. The changes introduced by python/cpython#9419 adds directory entries to ZIP files created by distutils. Co-authored-by: Aiden Nibali <dismaldenizen@gmail.com>
jcfr
added a commit
to scikit-build/scikit-build
that referenced
this pull request
May 11, 2019
This commit fixes tests that are checking content of sdist to account for changes introduced in Python 3.8 and backported to python 2.7, 3.6 and 3.7. The changes introduced by python/cpython#9419 adds directory entries to ZIP files created by distutils. Co-authored-by: Aiden Nibali <dismaldenizen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34738