Skip to content

Conversation

@magmax
Copy link
Contributor

@magmax magmax commented Sep 18, 2018

Method gather require to close parenthesis, but it is being closed twice.

https://bugs.python.org/issue33649

The `gather` method requires to close the parenthesis, but it is being closed twice.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Sep 18, 2018
@1st1 1st1 changed the title Fix syntax error on factorial example for asyncio bpo-33649: Fix syntax error on factorial example for asyncio Sep 18, 2018
@1st1 1st1 merged commit 9c53fa6 into python:master Sep 18, 2018
@miss-islington
Copy link
Contributor

Thanks @magmax for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1
Copy link
Member

1st1 commented Sep 18, 2018

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
The `gather` method requires to close the parenthesis, but it is being closed twice.
(cherry picked from commit 9c53fa6)

Co-authored-by: Miguel Ángel García <magmax@users.noreply.github.com>
@bedevere-bot
Copy link

GH-9388 is a backport of this pull request to the 3.7 branch.

1st1 pushed a commit that referenced this pull request Sep 18, 2018
The `gather` method requires to close the parenthesis, but it is being closed twice.
(cherry picked from commit 9c53fa6)

Co-authored-by: Miguel Ángel García <magmax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants