Skip to content

bpo-33649: Change "set_after" reference to say_after. #9384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1st1 merged 1 commit into from
Sep 18, 2018
Merged

bpo-33649: Change "set_after" reference to say_after. #9384

1st1 merged 1 commit into from
Sep 18, 2018

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 18, 2018 •
edited by bedevere-bot
Loading

I assume this falls under "Trivial changes, like fixing a typo, do not need an issue." If not, I apologize.

https://bugs.python.org/issue33649

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Sep 18, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Sep 18, 2018
@1st1 1st1 changed the title Change "set_after" reference to say_after. bpo-33649: Change "set_after" reference to say_after. Sep 18, 2018
@1st1 1st1 merged commit 7bfbda4 into python:master Sep 18, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Sep 18, 2018

Thanks @dhermes for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@1st1
Copy link
Member

1st1 commented Sep 18, 2018

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2018
@dhermes @miss-islington
Change "set_after" reference to say_after. (pythonGH-9384)
0b5fe67 
(cherry picked from commit 7bfbda4)

Co-authored-by: Danny Hermes <daniel.j.hermes@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Sep 18, 2018

GH-9386 is a backport of this pull request to the 3.7 branch.

1st1 pushed a commit that referenced this pull request Sep 18, 2018
@miss-islington @dhermes @1st1
Change "set_after" reference to say_after. (GH-9384) (GH-9386)
9a89fd6 
(cherry picked from commit 7bfbda4)

Co-authored-by: Danny Hermes <daniel.j.hermes@gmail.com>
@dhermes dhermes deleted the patch-1 branch September 18, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @the-knights-who-say-ni @miss-islington @1st1 @bedevere-bot