Link to the devguide's PR guidelines#932
Merged
brettcannon merged 1 commit intomasterfrom Mar 31, 2017
Merged
Conversation
Mariatta
reviewed
Mar 31, 2017
| in pull requests using the format of ``bpo-12345`` . If your pull request is in | ||
| response to a specific issue then please mention it in the title, | ||
| e.g. “bpo-12345: fix comment in tokenizer.c”. | ||
| project. Details on how to properly submit a pull request are covered in |
Member
There was a problem hiding this comment.
I would omit the word 'properly' . 🤔
Member
There was a problem hiding this comment.
Maybe I'm too picky. It's up to you. Looks good overall. :) Thanks.
Member
Author
There was a problem hiding this comment.
So I put that word in to make sure people read it, otherwise submitting a PR without following those guidelines won't lead to your PR being accepted outright, hence not done properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.