GH-92955: fix memory leak in code object lines and positions iterators#92956
GH-92955: fix memory leak in code object lines and positions iterators#92956corona10 merged 2 commits intopython:mainfrom
Conversation
corona10
left a comment
There was a problem hiding this comment.
@vstinner @erlend-aasland
I am not sure that we need to handle all these cases,
or is it better to wait for approval for converting static types into heap types from SC
|
These are the last static types which are accessible from python which are not finalized by the interpreter exit in core objects ( Also IIUC Heap types should be only used in extension modules not for interpreter core objects. From PEP 687:
|
|
Just to be clear this PR has nothing to do with conversion of static types to heap types. This PR only fixes a memory leak as static type was not finalized and is now finalized like other static types. |
That's nice
I just asked about one of Victor's last suggestions. |
I am finishing off his work of adding all static types which need to be finalized at exit and these are the last ones left. |
corona10
left a comment
There was a problem hiding this comment.
Since this will be the last change under Objects/*.c, I am happy to approve this change.
|
Thanks @corona10 |
Closes #92955