Narrow the Exception in test_urllib2 test. Catch URLError, not OSError#918
Merged
orsenthil merged 1 commit intopython:masterfrom Mar 31, 2017
orsenthil:fix_test
Merged
Narrow the Exception in test_urllib2 test. Catch URLError, not OSError#918orsenthil merged 1 commit intopython:masterfrom orsenthil:fix_test
orsenthil merged 1 commit intopython:masterfrom
orsenthil:fix_test
Conversation
…n urllib.request module.
|
@orsenthil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @facundobatista, @Yhg1s and @loewis to be potential reviewers. |
This was referenced Mar 31, 2017
Member
|
Shouldn't the comment |
Member
Author
|
@serhiy-storchaka, it is removed: https://github.com/python/cpython/pull/918/files - are you referring to a comment at some other place? |
| @@ -839,7 +838,7 @@ def test_file(self): | |||
| try: | |||
| h.file_open(req) | |||
| # XXXX remove OSError when bug fixed | |||
Member
There was a problem hiding this comment.
I'm referring to this comment.
Member
Author
There was a problem hiding this comment.
wow, it's right there in the context and still I missed it. Thanks for point out. I will remove it.
Member
Author
There was a problem hiding this comment.
It's removed now: #1020
Thank you for catching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileHandler catches OSError and raises them as URLError. Remove the reference to OSError in the tests.