bpo-29917: DOC: Remove link from PyMethodDef#890
Merged
orsenthil merged 6 commits intopython:masterfrom Mar 30, 2017
csabella:master
Merged
bpo-29917: DOC: Remove link from PyMethodDef#890orsenthil merged 6 commits intopython:masterfrom csabella:master
orsenthil merged 6 commits intopython:masterfrom
csabella:master
Conversation
Changed the parameter name from 'number' to 'x' to be consistent with documentation for other numeric functions, such as abs, float, math.floor, and mail.ceil. The use of 'number' seemed to indicate an object from the Number class, which with PEP 3141 was not valid for round since round is implemented for Real and not Complex. Not sure about this one, but changed the phrase '*ndigits* digits' to be "*ndigits* precision' to match the help() text. Moved the delegation line and expanded it to match the similar line in the float() section since that is the only other built-in over the Real class.
bpo-29677: DOC: clarify documentation for `round`
In C-API, The link target of the "type" struct member is the Python built-in "type".
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ashemedai and @gpshead to be potential reviewers. |
Member
|
Will backport to other branches. Thank you, @csabella ! |
orsenthil
added a commit
that referenced
this pull request
Mar 30, 2017
orsenthil
added a commit
that referenced
this pull request
Mar 30, 2017
orsenthil
added a commit
that referenced
this pull request
Mar 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C-API, the link target of the "type" struct member is the Python built-in "type".