Skip to content

bpo-16965: 2to3 now rewrites execfile() to open with 'rb'#8569

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-16965-2to3-execfile-rb-mode
Oct 13, 2018
Merged

bpo-16965: 2to3 now rewrites execfile() to open with 'rb'#8569
serhiy-storchaka merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-16965-2to3-execfile-rb-mode

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Jul 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Oct 12, 2018
serhiy-storchaka
serhiy-storchaka requested changes Oct 12, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a news entry.

@bedevere-bot

bedevere-bot commented Oct 12, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Oct 13, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-10-12-20-30-42.bpo-16965.xo5LAr.rst Outdated
@serhiy-storchaka serhiy-storchaka merged commit d4d6013 into python:master Oct 13, 2018
@miss-islington

miss-islington commented Oct 13, 2018

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2018
@ZackerySpytz @miss-islington
bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (pythonGH-…
eb4db15 
…8569)

(cherry picked from commit d4d6013)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 13, 2018

Copy link
Copy Markdown

GH-9838 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 13, 2018
@ZackerySpytz @miss-islington
bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (pythonGH-…
b0f426b 
…8569)

(cherry picked from commit d4d6013)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 13, 2018

Copy link
Copy Markdown

GH-9839 is a backport of this pull request to the 3.6 branch.

@miss-islington

miss-islington commented Oct 13, 2018

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d4d60134b29290049e28df54f23493de4f1824b6 2.7

miss-islington added a commit that referenced this pull request Oct 13, 2018
@miss-islington @ZackerySpytz
bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (GH-8569)
2238139 
(cherry picked from commit d4d6013)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Oct 13, 2018
@miss-islington @ZackerySpytz
bpo-16965: 2to3 now rewrites execfile() to open with 'rb'. (GH-8569)
950fa40 
(cherry picked from commit d4d6013)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Oct 15, 2018
@ZackerySpytz
[2.7] bpo-16965: 2to3 now rewrites execfile() to open with rb. (pytho…
ba51ee7 
…nGH-8569)

(cherry picked from commit d4d6013)
@bedevere-bot

bedevere-bot commented Oct 15, 2018

Copy link
Copy Markdown

GH-9890 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request Oct 16, 2018
@ZackerySpytz @serhiy-storchaka
[2.7] bpo-16965: 2to3 now rewrites execfile() to open with rb. (GH-8569…
f5e00f4 
…) (GH-9890)

(cherry picked from commit d4d6013)
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 16, 2018
@bedevere-bot

bedevere-bot commented Oct 16, 2018

Copy link
Copy Markdown

Hi! The buildbot AMD64 Windows7 SP1 2.7 has failed when building commit f5e00f4.

You can take a look here:

https://buildbot.python.org/all/#builders/68/builds/137

@bedevere-bot

bedevere-bot commented Oct 16, 2018

Copy link
Copy Markdown

Hi! The buildbot x86 Windows XP VS9.0 2.7 has failed when building commit f5e00f4.

You can take a look here:

https://buildbot.python.org/all/#builders/105/builds/261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @bedevere-bot @miss-islington @serhiy-storchaka @the-knights-who-say-ni