bpo-34263 Cap timeout submitted to epoll/select etc. to one day.#8532
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request You can check yourself Thanks again for your contribution, we look forward to reviewing it! |
Yes, let's just drop that sentence from docs in 3.8. |
vstinner
left a comment
There was a problem hiding this comment.
Is it possible to write a test? Maybe modify the constant during the test?
| _HAS_IPv6 = hasattr(socket, 'AF_INET6') | ||
|
|
||
| # Maximum timeout passed to select to avoid OS limitations | ||
| MAXIMUM_SELECT_TIMEOUT = 24 * 3600 |
There was a problem hiding this comment.
Hum, maybe it's better to make the constant private. What do you think @1st1?
Yeah, I discussed this with @MartinAltmayer and we ultimately decided that this test would be too fragile and complex. I don't this we need it.
Absolutely all constants in asyncio are already private and it's not recommended to modify them. |
|
Thanks @MartinAltmayer for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8586 is a backport of this pull request to the 3.7 branch. |
…honGH-8532) (cherry picked from commit 944451c) Co-authored-by: MartinAltmayer <martin.altmayer@web.de>
|
GH-8587 is a backport of this pull request to the 3.6 branch. |
…honGH-8532) (cherry picked from commit 944451c) Co-authored-by: MartinAltmayer <martin.altmayer@web.de>
My proposal was to add "_" prefix: _MAXIMUM_SELECT_TIMEOUT. I'm fine with the merged PR. |
"Timeouts (relative delay or absolute when) should not exceed one day."
Shall we update the doc? With this PR there is no reason anymore to disallow timeouts greater than one day in asyncio.
https://bugs.python.org/issue34263