Skip to content

bpo-34144: Fix of venv acvtivate.bat for win 10#8321

Merged
miss-islington merged 3 commits intopython:masterfrom
LorenzMende:bpo-34144
Apr 10, 2019
Merged

bpo-34144: Fix of venv acvtivate.bat for win 10#8321
miss-islington merged 3 commits intopython:masterfrom
LorenzMende:bpo-34144

Conversation

@LorenzMende
Copy link
Copy Markdown
Contributor

@LorenzMende LorenzMende commented Jul 18, 2018 •
edited by bedevere-bot
Loading

The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144

@LorenzMende
bpo-34144: Fix of venv acvtivate.bat for win 10
8cc4c11 
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)
@fvollmer
Copy link
Copy Markdown

fvollmer commented Jul 19, 2018

Fix works for me (Windows 10 Pro German, Codepage 850)

@schlauch
Copy link
Copy Markdown

schlauch commented Sep 22, 2018 •
edited
Loading

Any idea when this/such a fix is available and in which versions? I recently came across this on a Windows 7 system. It makes the usage of / getting started with virtual environments a little hard.

It tested the fix and it work.

@macetw
Copy link
Copy Markdown

macetw commented Oct 8, 2018

This fix also worked for me, when tested on the German platform.

@csabella csabella requested a review from zooba April 9, 2019 13:14
@csabella
Copy link
Copy Markdown
Contributor

csabella commented Apr 9, 2019 •
edited by bedevere-bot
Loading

Requesting review from @zooba as he contributed the original change in bpo-32409. There are also comments under that commit from November 2018 referencing this same issue.

zooba
zooba approved these changes Apr 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can be merged once the NEWS entry is added.

@csabella
Copy link
Copy Markdown
Contributor

csabella commented Apr 9, 2019

@LorenzMende, please add a NEWS entry for this to be merged.

@zooba, thank you for the review.

@LorenzMende
Copy link
Copy Markdown
Contributor Author

LorenzMende commented Apr 10, 2019

thx @zooba for the review, I tried blurb_it for the NEWS entry - first time.
Let me know if something is incorrect.

@zooba
Copy link
Copy Markdown
Member

zooba commented Apr 10, 2019

I improved the text a little (these turn into actual documentation, so it's worth making them easily readable) and tagged this to automerge once the CI completes.

Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 10, 2019

@LorenzMende: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6955d44 into python:master Apr 10, 2019
This was referenced May 3, 2019
Closed
Merged
@0xLeon
Copy link
Copy Markdown

0xLeon commented May 21, 2019

Will this be backported to 3.7 (and maybe earlier) as well? Personally I'm only interested in 3.7, but maybe for the sake of full coverage, it could be ported back to earlier versions as well.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 21, 2019

Thanks @LorenzMende for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 21, 2019

GH-13465 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2019
@LorenzMende @miss-islington
bpo-34144: Fix of venv acvtivate.bat for win 10 (pythonGH-8321)
cb2da71 
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144
(cherry picked from commit 6955d44)

Co-authored-by: Lorenz Mende <Lorenz.mende@gmail.com>
miss-islington added a commit that referenced this pull request May 21, 2019
@miss-islington @LorenzMende
bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321)
3c9c2dc 
The script needs to be updated to support win 10/ 1803 chcp.com command (output has trailing dot)

https://bugs.python.org/issue34144
(cherry picked from commit 6955d44)

Co-authored-by: Lorenz Mende <Lorenz.mende@gmail.com>
@s-trooper
Copy link
Copy Markdown

s-trooper commented Oct 1, 2019

will be that fixed for 3.6 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.