bpo-34126: fix crashes while profiling certain invalid calls #8300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We need to create PyCFunctionObject for tracing. | ||
| PyMethodDescrObject *descr = (PyMethodDescrObject*)func; | ||
| func = PyCFunction_NewEx(descr->d_method, stack[0], NULL); | ||
| if (nargs > 0 && tstate->use_tracing) { |
Member
There was a problem hiding this comment.
Why the check for tstate->c_profilefunc is missed?
Contributor
Author
There was a problem hiding this comment.
That check is actually redundant. The old code was checking tstate->use_tracing && tstate->c_profilefunc twice (once here and once in the C_TRACE macro). It's not wrong to keep the additional tstate->c_profilefunc check but it's just not needed.
serhiy-storchaka
approved these changes
Jul 18, 2018
Contributor
|
Thanks @jdemeyer for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2018
(cherry picked from commit 56868f9) Co-authored-by: jdemeyer <jdemeyer@cage.ugent.be>
|
GH-8371 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs backport to 3.7
https://bugs.python.org/issue34126