Skip to content

bpo-34123: Fix missed documentation update for dict.popitem(). #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rhettinger merged 2 commits into from
Jul 17, 2018
Merged

bpo-34123: Fix missed documentation update for dict.popitem(). #8292

rhettinger merged 2 commits into from
Jul 17, 2018

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Jul 16, 2018 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.7 labels Jul 16, 2018
tim-one
tim-one reviewed Jul 16, 2018
View reviewed changes
Copy link
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just wondering whether it would be helpful to add a "version changed in" blurb too so readers know that relying on LIFO creates a version dependence.

@rhettinger rhettinger merged commit 01b7d58 into python:master Jul 17, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Jul 17, 2018

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 17, 2018

GH-8307 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2018
@rhettinger @miss-islington
bpo-34123: Fix missed documentation update for dict.popitem(). (pytho…
a0b7b24 
…nGH-8292)

(cherry picked from commit 01b7d58)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger pushed a commit that referenced this pull request Jul 17, 2018
@miss-islington @rhettinger
bpo-34123: Fix missed documentation update for dict.popitem(). (GH-8292…
bfa8a35 
…) (GH#8307)
@rhettinger rhettinger deleted the dict-lifo-popitem branch July 17, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-one tim-one tim-one left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhettinger @miss-islington @bedevere-bot @tim-one @the-knights-who-say-ni