Skip to content

bpo-33476: Fix _header_value_parser.py when address group is missing final ';'#7484

Merged
zooba merged 1 commit into
python:masterfrom
corona10:bpo-33476
Jul 28, 2018
Merged

bpo-33476: Fix _header_value_parser.py when address group is missing final ';'#7484
zooba merged 1 commit into
python:masterfrom
corona10:bpo-33476

Conversation

@corona10

@corona10 corona10 commented Jun 7, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix _header_value_parser.py when address group is missing final ';'

Need to backport patch for 3.7, 3.6.

https://bugs.python.org/issue33476

@corona10 corona10 requested a review from a team as a code owner June 7, 2018 15:34
@corona10 corona10 force-pushed the bpo-33476 branch 3 times, most recently from 641ab12 to 12c2425 Compare June 8, 2018 01:53
@corona10

corona10 commented Jun 8, 2018

Copy link
Copy Markdown
Member Author

@bitdancer Please take a look 👍

bitdancer
bitdancer previously requested changes Jun 12, 2018
View reviewed changes
Comment thread Lib/test/test_email/test_parser.py Outdated

@bitdancer bitdancer Jun 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a test in test__header_value_parser, since that's the module that's being changed. Specifically, if you search the file for "# get_group" you'll see the set of tests for the function this PR modifies. Put the test in there.

@bedevere-bot

bedevere-bot commented Jun 12, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10

corona10 commented Jun 13, 2018

Copy link
Copy Markdown
Member Author

@bitdancer
Thanks! updated!

@corona10

corona10 commented Jun 25, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jun 25, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@corona10

corona10 commented Jul 5, 2018

Copy link
Copy Markdown
Member Author

@bitdancer
Please take a look

@zooba zooba dismissed bitdancer’s stale review July 28, 2018 12:54

The changes have been made according to the request.

@zooba zooba merged commit 8fe9eed into python:master Jul 28, 2018
@miss-islington

miss-islington commented Jul 28, 2018

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
@corona10 @miss-islington
bpo-33476: Fix _header_value_parser when address group is missing fin…
2e6a5bc 
…al ';' (pythonGH-7484)

(cherry picked from commit 8fe9eed)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 28, 2018

Copy link
Copy Markdown

GH-8522 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 28, 2018
@corona10 @miss-islington
bpo-33476: Fix _header_value_parser when address group is missing fin…
fea56ce 
…al ';' (pythonGH-7484)

(cherry picked from commit 8fe9eed)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 28, 2018

Copy link
Copy Markdown

GH-8524 is a backport of this pull request to the 3.6 branch.

@corona10 corona10 deleted the bpo-33476 branch July 28, 2018 12:57
miss-islington added a commit that referenced this pull request Jul 28, 2018
@miss-islington @corona10
bpo-33476: Fix _header_value_parser when address group is missing fin…
2be0124 
…al ';' (GH-7484)

(cherry picked from commit 8fe9eed)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington added a commit that referenced this pull request Jul 28, 2018
@miss-islington @corona10
bpo-33476: Fix _header_value_parser when address group is missing fin…
f17e001 
…al ';' (GH-7484)

(cherry picked from commit 8fe9eed)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @bedevere-bot @miss-islington @bitdancer @zooba @the-knights-who-say-ni