Skip to content

bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asvetlov merged 1 commit into from
May 29, 2018
Merged

bpo-33654: Support protocol type switching in SSLTransport.set_protocol() #7194

asvetlov merged 1 commit into from
May 29, 2018

Conversation

@1st1
Copy link
Member

@1st1 1st1 commented May 29, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov May 29, 2018 05:14
asvetlov
asvetlov approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asvetlov asvetlov merged commit 2179022 into python:master May 29, 2018
@miss-islington
Copy link
Contributor

miss-islington commented May 29, 2018

Thanks @1st1 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 29, 2018

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot
Copy link

bedevere-bot commented May 29, 2018

GH-7198 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2018
@1st1 @miss-islington
bpo-33654: Support protocol type switching in SSLTransport.set_protoc…
ac399ef 
…ol() (pythonGH-7194)

(cherry picked from commit 2179022)

Co-authored-by: Yury Selivanov <yury@magic.io>
miss-islington added a commit that referenced this pull request May 29, 2018
@miss-islington @1st1
bpo-33654: Support protocol type switching in SSLTransport.set_protoc…
be5d616 
…ol() (GH-7194)

(cherry picked from commit 2179022)

Co-authored-by: Yury Selivanov <yury@magic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1st1 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni