Skip to content

[3.7] bpo-33503: Fix the broken pypi link in the source and the documentation (GH-6814)#6872

Merged
encukou merged 1 commit into
python:3.7from
miss-islington:backport-19177fb-3.7
May 16, 2018
Merged

[3.7] bpo-33503: Fix the broken pypi link in the source and the documentation (GH-6814)#6872
encukou merged 1 commit into
python:3.7from
miss-islington:backport-19177fb-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented May 15, 2018

Copy link
Copy Markdown
Contributor

(cherry picked from commit 19177fb)

Co-authored-by: Stéphane Wirtel stephane@wirtel.be

https://bugs.python.org/issue33503

…on (pythonGH-6814)

(cherry picked from commit 19177fb)

Co-authored-by: Stéphane Wirtel <stephane@wirtel.be>
Comment thread Doc/library/ssl.rst
('DNS', 'pypi.org'),
('DNS', 'docs.python.org'),
('DNS', 'testpypi.python.org'),
('DNS', 'testpypi.org'),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be test.pypi.org ? testpypi.org gives me a 404

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't fix it in this PR, because I don't have the access on the cpython repository.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. How can you be able to make this change but not able to modify what change you are making?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR has been created by @miss-islington and I am not the author of this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's much of a problem that testpypi.org doesn't exist. This is just an example, it's outdated in other ways as well, and I don't think anyone would expect us to keep it up to date.
If you disagree, please bring it up in #6814 or in a new issue. The testpypi.org example is already in master.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@matrixise and @ned-deily: Backport status check is done, and it's a success ✅ .

@encukou encukou merged commit 51b2f6d into python:3.7 May 16, 2018
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @encukou!

@miss-islington miss-islington deleted the backport-19177fb-3.7 branch May 16, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants