Skip to content

bpo-31849: Fix warning in pyhash.c.#6799

Merged
methane merged 1 commit into
python:masterfrom
ajdavis:issue31849-hash-warnings
Jun 4, 2018
Merged

bpo-31849: Fix warning in pyhash.c.#6799
methane merged 1 commit into
python:masterfrom
ajdavis:issue31849-hash-warnings

Conversation

@ajdavis

@ajdavis ajdavis commented May 14, 2018

Copy link
Copy Markdown
Contributor

Fix a warning about signed/unsigned comparison.

https://bugs.python.org/issue31849

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@ajdavis

ajdavis commented May 14, 2018

Copy link
Copy Markdown
Contributor Author

I have signed the CLA, and now I've updated my b.p.o. profile with my GitHub username.

@tiran

tiran commented May 14, 2018

Copy link
Copy Markdown
Member

Thanks Jesse!

@methane methane merged commit a8eb585 into python:master Jun 4, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ajdavis for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2018
(cherry picked from commit a8eb585)

Co-authored-by: A. Jesse Jiryu Davis <jesse@emptysquare.net>
@bedevere-bot

Copy link
Copy Markdown

GH-7393 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2018
(cherry picked from commit a8eb585)

Co-authored-by: A. Jesse Jiryu Davis <jesse@emptysquare.net>
@bedevere-bot

Copy link
Copy Markdown

GH-7394 is a backport of this pull request to the 3.6 branch.

@ajdavis

ajdavis commented Jun 4, 2018

Copy link
Copy Markdown
Contributor Author

Thanks everyone for reviewing and merging, and thanks for everyone's hard work on CPython's contributor experience. I last sprinted on CPython at PyCon Montreal three years ago and the contributor experience wasn't good; it's radically improved and I appreciate how much effort was spent to achieve this.

miss-islington added a commit that referenced this pull request Jun 4, 2018
(cherry picked from commit a8eb585)

Co-authored-by: A. Jesse Jiryu Davis <jesse@emptysquare.net>
miss-islington added a commit that referenced this pull request Jun 4, 2018
(cherry picked from commit a8eb585)

Co-authored-by: A. Jesse Jiryu Davis <jesse@emptysquare.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants