bpo-33204: IDLE - revise and extend colorizer test#6347
Merged
Conversation
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6348 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
Followup to primary PR for the issue, pythonGH-6344. (cherry picked from commit 55966f3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
Followup to primary PR for the issue, pythonGH-6344. (cherry picked from commit 55966f3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-6349 is a backport of this pull request to the 3.6 branch. |
Member
Author
|
I think not. If the re correctly splits one combination correctly, there is no reason it should not do the same with all similar combinations. " and'' " is also legal, as are " ''and'' " and " ''or'' ". I should better think about covering things that could independently fail, like multiline strings, and automating the test. |
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
Member
|
Only these three keywords end with legal string prefixes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33204