Skip to content

bpo-27428: Fix WindowsRegistryFinder documentation#6061

Merged
brettcannon merged 2 commits into
python:masterfrom
Himanshu-Lakhara:fix-issue-27428
Mar 23, 2018
Merged

bpo-27428: Fix WindowsRegistryFinder documentation#6061
brettcannon merged 2 commits into
python:masterfrom
Himanshu-Lakhara:fix-issue-27428

Conversation

@Himanshu-Lakhara

@Himanshu-Lakhara Himanshu-Lakhara commented Mar 10, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Update documentation to clarify WindowsRegistryFinder
implement MetaPathFinder

https://bugs.python.org/issue27428

@Himanshu-Lakhara
bpo-27428: Fix WindowsRegistryFinder documentation
51bf883 
Update documentation to clarify that WindowsRegistryFinder
implement MetaPathFinder
@brettcannon brettcannon self-assigned this Mar 10, 2018
@brettcannon brettcannon added needs backport to 3.6 docs Documentation in the Doc dir labels Mar 10, 2018
@brettcannon

brettcannon commented Mar 10, 2018

Copy link
Copy Markdown
Member

Thanks for the patch, @Himanshu-Lakhara ! I'll try to review this sometime in the next week or two.

@Himanshu-Lakhara

Himanshu-Lakhara commented Mar 17, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing @brettcannon and Sorry for delayed response. Since this is my first cpython PR and first PR on GitHub so I request you to please be thorough. I have previous experience contributing to open source project but not on GitHub. So It is possible that I might have missed something.

Thanks again for your time. I'll try to be more responsive.

@brettcannon

brettcannon commented Mar 19, 2018

Copy link
Copy Markdown
Member

@Himanshu-Lakhara no worries. I've been very busy as of late so I have not gotten around to doing a review anyway (although I cursory look seems good 😃 ).

@brettcannon

brettcannon commented Mar 23, 2018

Copy link
Copy Markdown
Member

I tweaked the news entry, but otherwise LGTM! Once CI passes again I will merge this.

@brettcannon brettcannon merged commit 5cbb841 into python:master Mar 23, 2018
@miss-islington

miss-islington commented Mar 23, 2018

Copy link
Copy Markdown
Contributor

Thanks @Himanshu-Lakhara for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Mar 23, 2018

Copy link
Copy Markdown

GH-6205 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
@Himanshu-Lakhara @miss-islington
bpo-27428: Fix WindowsRegistryFinder documentation to list appropriat…
a266229 
…e ABC (pythonGH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
@Himanshu-Lakhara @miss-islington
bpo-27428: Fix WindowsRegistryFinder documentation to list appropriat…
9e4c004 
…e ABC (pythonGH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
@bedevere-bot

bedevere-bot commented Mar 23, 2018

Copy link
Copy Markdown

GH-6206 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 23, 2018
@miss-islington @Himanshu-Lakhara
bpo-27428: Fix WindowsRegistryFinder documentation to list appropriat…
45738ed 
…e ABC (GH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
miss-islington added a commit that referenced this pull request Mar 23, 2018
@miss-islington @Himanshu-Lakhara
bpo-27428: Fix WindowsRegistryFinder documentation to list appropriat…
643a781 
…e ABC (GH-6061)

(cherry picked from commit 5cbb841)

Co-authored-by: Himanshu Lakhara <himanshulakhara1947@gmail.com>
@Himanshu-Lakhara Himanshu-Lakhara deleted the fix-issue-27428 branch March 24, 2018 04:38
@Himanshu-Lakhara

Himanshu-Lakhara commented Mar 24, 2018

Copy link
Copy Markdown
Contributor Author

Thanks @brettcannon for merging and tweaking news entry. It was my first PR to cpython and first PR on GitHub. Learned cpython workflow and Feeling more confident to take up some coding task.

Thanks again for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

@brettcannon brettcannon

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Himanshu-Lakhara @brettcannon @miss-islington @bedevere-bot @the-knights-who-say-ni