bpo-32984: IDLE - set __file__ for startup files#5981
Merged
Conversation
csabella
reviewed
Mar 5, 2018
| source = fp.read() | ||
| if use_subprocess: | ||
| source = (f"__file__ = r'{os.path.abspath(filename)}'\n" + | ||
| source + "\ndel __file__") |
Contributor
There was a problem hiding this comment.
This gives a SyntaxError if there's an unescaped quote in the path or file name (such as /home/cheryl's/tests/).
Using triple quotes works:
f"__file__ = r'''{os.path.abspath(filename)}'''\n"
Member
Author
There was a problem hiding this comment.
Great catch. Changed.
csabella
reviewed
Mar 5, 2018
| input prompt. For IDLE, -s runs a file named in environmental variable | ||
| IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to | ||
| the startup file name before running the file and unsets it before the first | ||
| prompt. IDLE now does the same when run normally, without the -n option. |
Contributor
There was a problem hiding this comment.
Set __file__ while running a startup file. Like Python, IDLE optionally
runs one startup file in the Shell window before presenting the first
interactive input prompt. For IDLE, -s runs a file named in
environmental variable :envvar:IDLESTARTUP or :envvar:PYTHONSTARTUP;
-r file runs file. Python sets __file__ to the startup file
name before running the file and unsets it before the first prompt. IDLE now
does the same when run normally, without the -n option.
Member
Author
There was a problem hiding this comment.
Thanks. by 'editing', I could see and copy the markup (and maybe learn better). I changed one clause to -r file runs file, which I can preview here ;-).
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option. (cherry picked from commit 22c82be) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-5986 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option. (cherry picked from commit 22c82be) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-5987 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option. (cherry picked from commit 22c82be) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 5, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option. (cherry picked from commit 22c82be) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-5993 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 5, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option. (cherry picked from commit 22c82be) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
Like Python, IDLE optionally runs one startup file in the Shell window before presenting the first interactive input prompt. For IDLE, option -s runs a file named in environmental variable IDLESTARTUP or PYTHONSTARTUP; -r file runs file. Python sets __file__ to the startup file name before running the file and unsets it before the first prompt. IDLE now does the same when run normally, without the -n option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32984