Skip to content

Fixed logging library doc typo #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 1 commit into from
Feb 28, 2018
Merged

Fixed logging library doc typo #5942

Mariatta merged 1 commit into from
Feb 28, 2018

Conversation

@jdswalker
Copy link
Contributor

@jdswalker jdswalker commented Feb 28, 2018

On line 331 of the documentation for the logging library, the typo "picked" has been changed to "pickled".

@Mariatta Mariatta merged commit 982c723 into python:master Feb 28, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Feb 28, 2018

Thanks @jdswalker for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Mariatta commented Feb 28, 2018

Thanks @jdswalker and congrats on your first contribution to CPython 🌮

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 28, 2018
@jdswalker @miss-islington
Fix typo in logging doc: picked -> pickled (pythonGH-5942)
a99d586 
(cherry picked from commit 982c723)

Co-authored-by: James Walker <19191463+jdswalker@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 28, 2018

GH-5943 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 28, 2018
@miss-islington @jdswalker
Fix typo in logging doc: picked -> pickled (GH-5942)
82734a6 
(cherry picked from commit 982c723)

Co-authored-by: James Walker <19191463+jdswalker@users.noreply.github.com>
@jdswalker
Copy link
Contributor Author

jdswalker commented Mar 1, 2018

Thank you @Mariatta. Hopefully, I'll be able to contribute something more significant in the future. Have a good day. 🌞

@jdswalker jdswalker deleted the FixLoggingDocTypo branch March 1, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdswalker @miss-islington @Mariatta @bedevere-bot @the-knights-who-say-ni