Skip to content

bpo-32964: Reuse a testing implementation of the path protocol in tests. #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 3 commits into from
Mar 2, 2018
Merged

bpo-32964: Reuse a testing implementation of the path protocol in tests. #5930

serhiy-storchaka merged 3 commits into from
Mar 2, 2018

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 27, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka merged commit b21d155 into python:master Mar 2, 2018
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2018

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2018

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the simple-test-path branch March 2, 2018 09:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 2, 2018
@serhiy-storchaka @miss-islington
bpo-32964: Reuse a testing implementation of the path protocol in tes…
4b4eaae 
…ts. (pythonGH-5930)

(cherry picked from commit b21d155)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2018

GH-5957 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Mar 2, 2018

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b21d155f57d284aecf9092a9bd24258293965c2f 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 2, 2018
@serhiy-storchaka
[3.6] bpo-32964: Reuse a testing implementation of the path protocol …
1f2c956 
…in tests. (pythonGH-5930).

(cherry picked from commit b21d155)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Mar 2, 2018

GH-5958 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Mar 2, 2018
@miss-islington @serhiy-storchaka
bpo-32964: Reuse a testing implementation of the path protocol in tes…
a13b654 
…ts. (GH-5930)

(cherry picked from commit b21d155)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Mar 3, 2018
@serhiy-storchaka
[3.6] bpo-32964: Reuse a testing implementation of the path protocol …
fbdd075 
…in tests. (GH-5930). (GH-5958)

(cherry picked from commit b21d155)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @bedevere-bot @miss-islington @the-knights-who-say-ni