Skip to content

bpo-28124: deprecate ssl.wrap_socket()#5888

Merged
tiran merged 1 commit intopython:masterfrom
tiran:bpo-28124-ssl-docs
Feb 27, 2018
Merged

bpo-28124: deprecate ssl.wrap_socket()#5888
tiran merged 1 commit intopython:masterfrom
tiran:bpo-28124-ssl-docs

Conversation

@tiran
Copy link
Copy Markdown
Member

@tiran tiran commented Feb 25, 2018

The ssl module function ssl.wrap_socket() has been de-emphasized
and deprecated in favor of the more secure and efficient
SSLContext.wrap_socket() method.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue28124

@tiran
Copy link
Copy Markdown
Member Author

tiran commented Feb 25, 2018

IMO the documentation of 3.6 and 2.7 should be updated, too. Of course the deprecation message must be removed first.

@tiran tiran added the docs Documentation in the Doc dir label Feb 25, 2018
@tiran tiran force-pushed the bpo-28124-ssl-docs branch 2 times, most recently from 52b06eb to 26f4a26 Compare February 27, 2018 07:54
The ssl module function ssl.wrap_socket() has been de-emphasized
and deprecated in favor of the more secure and efficient
SSLContext.wrap_socket() method.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Copy Markdown
Member Author

tiran commented Feb 27, 2018

I have removed backport to 2.7 and3.6 to prevent @miss-islington from auto-merging the commits.

@tiran tiran merged commit 90f05a5 into python:master Feb 27, 2018
@bedevere-bot
Copy link
Copy Markdown

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@tiran tiran deleted the bpo-28124-ssl-docs branch February 27, 2018 08:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2018
The ssl module function ssl.wrap_socket() has been de-emphasized
and deprecated in favor of the more secure and efficient
SSLContext.wrap_socket() method.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 90f05a5)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link
Copy Markdown

GH-5924 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 27, 2018
The ssl module function ssl.wrap_socket() has been de-emphasized
and deprecated in favor of the more secure and efficient
SSLContext.wrap_socket() method.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 90f05a5)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants