Skip to content

bpo-32841: Asyncio.Condition prevents cancellation#5665

Merged
asvetlov merged 6 commits into
python:masterfrom
bharel:bpo-32841
Feb 14, 2018
Merged

bpo-32841: Asyncio.Condition prevents cancellation#5665
asvetlov merged 6 commits into
python:masterfrom
bharel:bpo-32841

Conversation

@bharel

@bharel bharel commented Feb 13, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Alright.
Fixed, added tests, and added news.

https://bugs.python.org/issue32841

@bharel bharel requested review from 1st1 and asvetlov as code owners February 13, 2018 22:25
@1st1

1st1 commented Feb 13, 2018

Copy link
Copy Markdown
Member

@asvetlov Andrew please take a look.

@bharel

bharel commented Feb 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@1st1 Hey mate, seems like the build failed because of a whitespace issue in the tests file. I have a fully enabled linter which doesn't really know what whitespace issue is it talking about.
May you lend me a hand here?

@bharel

bharel commented Feb 13, 2018

Copy link
Copy Markdown
Contributor Author

Alright. Seems like whitespace issues were fixed even though they weren't on any part of my code >.<

asvetlov
asvetlov approved these changes Feb 14, 2018
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asvetlov asvetlov merged commit 5746510 into python:master Feb 14, 2018
@miss-islington

miss-islington commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

Thanks @bharel for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 14, 2018

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@bedevere-bot

bedevere-bot commented Feb 14, 2018

Copy link
Copy Markdown

GH-5682 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2018
@bharel @miss-islington
bpo-32841: Fix cancellation in awaiting asyncio.Condition (pythonGH-5665
52d25dc 
)

(cherry picked from commit 5746510)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 14, 2018
@bharel @miss-islington
bpo-32841: Fix cancellation in awaiting asyncio.Condition (pythonGH-5665
d802c42 
)

(cherry picked from commit 5746510)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 14, 2018

Copy link
Copy Markdown

GH-5683 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Feb 14, 2018
@miss-islington @bharel
bpo-32841: Fix cancellation in awaiting asyncio.Condition (GH-5665)
8caee0f 
(cherry picked from commit 5746510)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
asvetlov pushed a commit that referenced this pull request Feb 14, 2018
@miss-islington @bharel @asvetlov
bpo-32841: Fix cancellation in awaiting asyncio.Condition (GH-5665) (G…
a23eeca 
…H-5683)

(cherry picked from commit 5746510)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
@bharel bharel deleted the bpo-32841 branch December 23, 2019 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bharel @1st1 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni