bpo-32826: Add "encoding=utf-8" to open() in idle_test/test_help_about.#5639
Merged
Conversation
On at least one system, readline() causes decoding of multiple lines, including line 27 of idlelib/CREDITS.txt, with a non-ascii character.
|
|
||
| for button, printer, name in button_sources: | ||
| with self.subTest(name=name): | ||
| if name=='license': raise NameError() |
Member
Author
There was a problem hiding this comment.
Yes. Test of test failure. Fixed.
| @@ -0,0 +1,5 @@ | |||
| Add "encoding=utf-8" to open() in idle_test/test_help_about. | |||
|
|
|||
Member
There was a problem hiding this comment.
I think these empty lines are not needed. Bug in blurb?
Member
Author
There was a problem hiding this comment.
Yes, they were not in the file as I wrote it. Fixed with online editor.
serhiy-storchaka
approved these changes
Feb 12, 2018
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2018
…t. (pythonGH-5639) GUI test test_file_buttons() only looks at initial ascii-only lines, but failed on systems where open() defaults to 'ascii' because readline() internally reads and decodes far enough ahead to encounter a non-ascii character in CREDITS.txt. (cherry picked from commit f34e03e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-5642 is a backport of this pull request to the 3.7 branch. |
|
GH-5643 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2018
…t. (pythonGH-5639) GUI test test_file_buttons() only looks at initial ascii-only lines, but failed on systems where open() defaults to 'ascii' because readline() internally reads and decodes far enough ahead to encounter a non-ascii character in CREDITS.txt. (cherry picked from commit f34e03e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 12, 2018
…t. (GH-5639) GUI test test_file_buttons() only looks at initial ascii-only lines, but failed on systems where open() defaults to 'ascii' because readline() internally reads and decodes far enough ahead to encounter a non-ascii character in CREDITS.txt. (cherry picked from commit f34e03e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Feb 12, 2018
…t. (GH-5639) GUI test test_file_buttons() only looks at initial ascii-only lines, but failed on systems where open() defaults to 'ascii' because readline() internally reads and decodes far enough ahead to encounter a non-ascii character in CREDITS.txt. (cherry picked from commit f34e03e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On at least one system, readline() causes decoding of multiple lines,
including line 27 of idlelib/CREDITS.txt, with a non-ascii character.
https://bugs.python.org/issue32826