bpo-6135: Fix subprocess.check_output() doc to mention changes in 3.6
#5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges done in 3.6
subprocess.check_output() not mentionning changes in 3.6subprocess.check_output() not mentioning changes in 3.6
Member
|
Thank you for this contribution
Thank you |
Member
|
We can do without a bpo issue on this one, it's a documentation update. Also I would not bother describing the meaning the parameters in the check_output docs. It already refers to run for full details. I added a note to the versionchanged text that refers people to look at run for details on the new parameters. |
subprocess.check_output() not mentioning changes in 3.6subprocess.check_output() doc to mention changes in 3.6
Contributor
|
Thanks @brice-gros for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2018
…ythonGH-5564) Fixes the documentation for `subprocess.check_output()` not mentioning that the encoding and errors parameters were added in 3.6. (cherry picked from commit fc1ce81) Co-authored-by: Brice Gros <brice-gros@users.noreply.github.com>
|
GH-5572 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2018
…ythonGH-5564) Fixes the documentation for `subprocess.check_output()` not mentioning that the encoding and errors parameters were added in 3.6. (cherry picked from commit fc1ce81) Co-authored-by: Brice Gros <brice-gros@users.noreply.github.com>
|
GH-5573 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More parameters were supported by
subprocess.check_output()in python 3.6See:
Now the doc mentions these changes allowing users targeting multiple python 3 versions to be aware not to use these parameters.
https://bugs.python.org/issue6135