Skip to content

bpo-32735: Fix typo in f-strings example #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 1 commit into from
Jan 31, 2018
Merged

bpo-32735: Fix typo in f-strings example #5464

Mariatta merged 1 commit into from
Jan 31, 2018

Conversation

@csabella
Copy link
Contributor

@csabella csabella commented Jan 31, 2018 •
edited by bedevere-bot
Loading

bitdancer
bitdancer approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@bitdancer bitdancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mariatta Mariatta merged commit b299393 into python:master Jan 31, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Jan 31, 2018

Thanks @csabella for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2018
@csabella @miss-islington
bpo-32735: Fix typo in f-strings datetime format specifier example (p…
8114645 
…ythonGH-5464)

The f-string example for using datetime format specifier does not match the given output.
Changed the format from %b to %B so it matches the output of "January".
(cherry picked from commit b299393)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 31, 2018

GH-5465 is a backport of this pull request to the 3.6 branch.

@csabella csabella deleted the stringexample branch January 31, 2018 21:50
@csabella
Copy link
Contributor Author

csabella commented Jan 31, 2018

Thanks!

Mariatta pushed a commit that referenced this pull request Jan 31, 2018
@miss-islington @csabella @Mariatta
bpo-32735: Fix typo in f-strings datetime format specifier example (G…
581ce25 
…H-5464) (GH-5465)

The f-string example for using datetime format specifier does not match the given output.
Changed the format from %b to %B so it matches the output of "January".
(cherry picked from commit b299393)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jan 31, 2018
@csabella @ned-deily
bpo-32735: Fix typo in f-strings datetime format specifier example (p…
70e3042 
…ythonGH-5464)

The f-string example for using datetime format specifier does not match the given output.
Changed the format from %b to %B so it matches the output of "January".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csabella @miss-islington @bedevere-bot @bitdancer @Mariatta @the-knights-who-say-ni